Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to core injection #299

Merged
merged 7 commits into from
Dec 13, 2022
Merged

Move to core injection #299

merged 7 commits into from
Dec 13, 2022

Conversation

zerebos
Copy link
Member

@zerebos zerebos commented Dec 11, 2022

After speaking with Strencher, rather than dealing with the vulnerability of renaming the ASAR and potentially corrupting Discord installs, we decided to move all platforms to discord_desktop_core style injection.

Copy link
Member

@Tropix126 Tropix126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

src/renderer/actions/install.js Outdated Show resolved Hide resolved
src/renderer/actions/paths.js Outdated Show resolved Hide resolved
@zerebos zerebos merged commit fa58466 into development Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants